Github user VinceShieh commented on a diff in the pull request:
https://github.com/apache/spark/pull/15055#discussion_r88427044
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/PCA.scala ---
@@ -34,6 +34,7 @@ import org.apache.spark.rdd.RDD
import org.apache.spark.sql._
import org.apache.spark.sql.functions._
import org.apache.spark.sql.types.{StructField, StructType}
+import org.apache.spark.util.VersionUtils._
--- End diff --
hmm, personally I think it's fine to keep it this way, though it's only
'majorVersion' needed here, so we can import
org.apache.spark.util.VersionUtils.majorVersion instead. Sounds good to you?
@srowen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
