Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r88541878
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1962,6 +1962,21 @@ private[spark] object Utils extends Logging {
path
}
+ /**
+ * Updates Spark config with properties from a set of Properties.
+ * Provided properties have the highest priority.
+ */
+ def updateSparkConfigFromProperties(
+ conf: SparkConf,
+ properties: Map[String, String]) : Unit = {
+ properties.filter { case (k, v) =>
+ k.startsWith("spark.")
+ }.foreach { case (k, v) =>
+ conf.set(k, v)
+ sys.props.getOrElseUpdate(k, v)
--- End diff --
Why is this method updating system properties? The name nor the scaladoc
mention that fact, and this is a pretty important thing the method does. Not
only that but the behavior is different from what it does to the SparkConf (set
if not yet set, instead of always set).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
