Github user Yunni commented on the issue: https://github.com/apache/spark/pull/15874 Hi @jkbradley, **MinHash** Yes, I agree that I shouldn't have said it's perfect hashing. Theoretically, it should be Min-wise Independent Permutation Family. What we used here is 2-independent (or 2-universal) hash families, which is approximately min-wise independent. Reference: http://people.csail.mit.edu/mip/papers/kwise-lb/kwise-lb.pdf **approxNearestNeighbors** I still think in the case of OR-amplification, the only way is to scan a number of candidates k times the average bucket size. I would like to understand more about what you proposed. I have left the note in the scaladoc and let us have more discussion in future releases. **AND-amplification** I've open a ticket in SPARK-18450 for AND-amplification. I am wondering if we are including it in 2.1.0?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org