Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15907#discussion_r88589179
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/SortBenchmark.scala
---
@@ -80,7 +80,7 @@ class SortBenchmark extends BenchmarkBase {
}
val buf = new LongArray(MemoryBlock.fromLongArray(array))
timer.startTiming()
- RadixSort.sort(buf, size, 0, 7, false, false)
+ RadixSort.sort(buf, size.toLong, 0, 7, false, false)
--- End diff --
As I wrote before, I wanted to emphasis the difference of types between
caller and callee.
It is OK to reply on implicit cast, done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
