Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15652#discussion_r88790872
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2142,9 +2142,10 @@ private[spark] object Utils extends Logging {
*/
def startServiceOnPort[T](
startPort: Int,
- startService: Int => (T, Int),
+ startService: (Int, Int) => (T, Int),
conf: SparkConf,
- serviceName: String = ""): (T, Int) = {
+ serviceName: String = "",
+ securePort: Int = 0): (T, Int) = {
--- End diff --
I don't like what you did here. As you yourself explained, not all
consumers of this API have the concept of separate secure and non-secure ports.
And as I explained in my previous comments, it's possible to fix the problem
you introduced without changing this API.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
