Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15888#discussion_r88808475
--- Diff: R/pkg/R/sparkR.R ---
@@ -550,24 +555,27 @@ processSparkPackages <- function(packages) {
#
# @param sparkHome directory to find Spark package.
# @param master the Spark master URL, used to check local or remote mode.
+# @param deployMode whether to deploy your driver on the worker nodes
(cluster)
+# or locally as an external client (client).
# @return NULL if no need to update sparkHome, and new sparkHome otherwise.
-sparkCheckInstall <- function(sparkHome, master) {
+sparkCheckInstall <- function(sparkHome, master, deployMode) {
if (!isSparkRShell()) {
if (!is.na(file.info(sparkHome)$isdir)) {
msg <- paste0("Spark package found in SPARK_HOME: ", sparkHome)
message(msg)
NULL
} else {
- if (!nzchar(master) || isMasterLocal(master)) {
- msg <- paste0("Spark not found in SPARK_HOME: ",
- sparkHome)
+ if (isMasterLocal(master)) {
+ msg <- paste0("Spark not found in SPARK_HOME: ", sparkHome)
message(msg)
packageLocalDir <- install.spark()
packageLocalDir
- } else {
+ } else if (isClientMode(master) || deployMode == "client") {
--- End diff --
ah yes..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
