Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/15840
@hvanhovell Could you review this pr again, please?
I reverted some commits which replace null checking with
`ctx.nullSafeExec()` and then modified some null checkings to `${isNull} ? null
: ${value}` pattern in `objects.scala` because Janino can optimize codes like
`false ? a : b` to `b`, which we found at #15901.
We expect `isNull == "false"` for `expr.nullable = false` (not always,
though), so we can expect Janino will optimize them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
