Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r88898200
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -603,7 +603,14 @@ case class ExternalMapToCatalyst private(
override def foldable: Boolean = false
- override def dataType: MapType = MapType(keyConverter.dataType,
valueConverter.dataType)
+ override def dataType: MapType = {
+ val isPrimitiveType = valueType match {
+ case BooleanType | ByteType | ShortType | IntegerType | LongType |
+ FloatType | DoubleType => true
+ case _ => false
+ }
+ MapType(keyConverter.dataType, valueConverter.dataType,
!isPrimitiveType)
--- End diff --
looking at the places we create `ExternalMapToCatalyst`, I think we do know
what the map value type is and if it can be null. How about we add a
`valueNullable: Boolean` parameter in `ExternalMapToCatalyst` like what we did
for `Invoke`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
