Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15966#discussion_r89008907
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -83,10 +89,8 @@ class JDBCOptions(
val lowerBound = parameters.getOrElse(JDBC_LOWER_BOUND, null)
// the upper bound of the partition column
val upperBound = parameters.getOrElse(JDBC_UPPER_BOUND, null)
- // the number of partitions
- val numPartitions = parameters.getOrElse(JDBC_NUM_PARTITIONS, null)
require(partitionColumn == null ||
- (lowerBound != null && upperBound != null && numPartitions != null),
+ (lowerBound != null && upperBound != null && numPartitions.isDefined),
s"If '$JDBC_PARTITION_COLUMN' is specified then '$JDBC_LOWER_BOUND',
'$JDBC_UPPER_BOUND'," +
s" and '$JDBC_NUM_PARTITIONS' are required.")
--- End diff --
Ur, for me, this error message looks correct. `JDBC_NUM_PARTITION` is
indenpendent of the others, but `JDBC_PARTITION_COLUMN` requires the others
(including `JDBC_NUM_PARTITION`), isn't it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
