Github user cmccabe commented on a diff in the pull request:
https://github.com/apache/spark/pull/1486#discussion_r17027807
--- Diff: core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala ---
@@ -309,4 +322,44 @@ private[spark] object HadoopRDD {
f(inputSplit, firstParent[T].iterator(split, context))
}
}
+
+ private[spark] class Hadoop2Classes {
--- End diff --
I can't think of a better name here. "ClassesAndMethods" seems too
cumbersome.
In my mind, at least, "Hadoop2Classes" immediately makes it clear what is
going on. Plus, classes are really not of much use without methods. We don't
say "please implement a Foo class and Foo methods", we just say "please
implement a Foo class". The methods are assumed to be part of the class, just
as they are here.
I'm open to suggestions, though...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
