Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15848#discussion_r89098150
  
    --- Diff: 
streaming/src/test/java/org/apache/spark/streaming/JavaAPISuite.java ---
    @@ -1244,7 +1244,15 @@ public void testCountByValue() {
         JavaTestUtils.attachTestOutputStream(counted);
         List<List<Tuple2<String, Long>>> result = 
JavaTestUtils.runStreams(ssc, 3, 3);
     
    -    Assert.assertEquals(expected, result);
    +
    +
    +    for (int i=0;i<expected.size();i++) {
    --- End diff --
    
    This only asserts that the actual result is a superset of the expected 
results. It won't catch the case that it contains unexpected values. You could 
check both ways.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to