Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15977#discussion_r89152336
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
---
@@ -120,7 +120,13 @@ object JDBCRDD extends Logging {
case StringStartsWith(attr, value) => s"${attr} LIKE '${value}%'"
case StringEndsWith(attr, value) => s"${attr} LIKE '%${value}'"
case StringContains(attr, value) => s"${attr} LIKE '%${value}%'"
- case In(attr, value) => s"$attr IN (${compileValue(value)})"
+ case In(attr, value) =>
--- End diff --
NIT: It is shorter to put both options in different case statements:
```scala
...
case In(attr, values) if value.nonEmpty => s"$attr IN
(${compileValue(value)})"
case In(_, _) => "false"
...
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
