Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15874#discussion_r89175604
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/BucketedRandomProjectionLSHSuite.scala
---
@@ -43,70 +43,73 @@ class RandomProjectionSuite
}
test("params") {
- ParamsSuite.checkParams(new RandomProjection)
- val model = new RandomProjectionModel("rp", randUnitVectors =
Array(Vectors.dense(1.0, 0.0)))
+ ParamsSuite.checkParams(new BucketedRandomProjectionLSH)
+ val model = new BucketedRandomProjectionLSHModel(
+ "brp", randUnitVectors = Array(Vectors.dense(1.0, 0.0)))
ParamsSuite.checkParams(model)
}
- test("RandomProjection: default params") {
- val rp = new RandomProjection
- assert(rp.getOutputDim === 1.0)
+ test("BucketedRandomProjectionLSH: default params") {
+ val brp = new BucketedRandomProjectionLSH
+ assert(brp.getNumHashTables === 1.0)
}
test("read/write") {
- def checkModelData(model: RandomProjectionModel, model2:
RandomProjectionModel): Unit = {
+ def checkModelData(
+ model: BucketedRandomProjectionLSHModel,
+ model2: BucketedRandomProjectionLSHModel
+ ): Unit = {
--- End diff --
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
