Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15896#discussion_r89188321
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/cache.scala ---
@@ -49,10 +50,18 @@ case class CacheTableCommand(
}
-case class UncacheTableCommand(tableIdent: TableIdentifier) extends
RunnableCommand {
+case class UncacheTableCommand(
+ tableIdent: TableIdentifier,
+ ifExists: Boolean) extends RunnableCommand {
override def run(sparkSession: SparkSession): Seq[Row] = {
- sparkSession.catalog.uncacheTable(tableIdent.quotedString)
+ val tableId = tableIdent.quotedString
+ try {
+ sparkSession.catalog.uncacheTable(tableId)
+ } catch {
+ case _: NoSuchTableException if ifExists => // don't throw
+ logInfo(s"Asked to uncache table $tableId which doesn't exist.")
--- End diff --
Minor: Lets not log it, logs typically get swallowed by the environment
anyway. See for example:
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala#L206
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
