Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15966#discussion_r89195812
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcRelationProvider.scala
 ---
    @@ -39,7 +39,7 @@ class JdbcRelationProvider extends 
CreatableRelationProvider
           null
         } else {
           JDBCPartitioningInfo(
    -        partitionColumn, lowerBound.toLong, upperBound.toLong, 
numPartitions.toInt)
    +        partitionColumn, lowerBound.toLong, upperBound.toLong, 
numPartitions.get)
    --- End diff --
    
    is this safe to call get on? calling get on an option is always dangerous 
and not future proof.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to