Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15971#discussion_r89242027
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala
---
@@ -95,6 +95,30 @@ class EventLoggingListenerSuite extends SparkFunSuite
with LocalSparkContext wit
}
}
+ test("Event logging with password redaction") {
+ val secretPassword = "secret_password"
+ val conf = getLoggingConf(testDirPath,
None).set("spark.executorEnv.HADOOP_CREDSTORE_PASSWORD",
+ secretPassword)
+ sc = new SparkContext("local-cluster[2,2,1024]", "test", conf)
--- End diff --
Both are not doing the exact same thing. There's logic in the
`EventLoggingListener` code that also needs to be tested. But you can have a
more targeted unit test instead of running a distributed Spark application.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
