Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2188#discussion_r17032061
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/InMemoryColumnarTableScan.scala
---
@@ -110,8 +199,26 @@ private[sql] case class InMemoryColumnarTableScan(
attributes.map(a => relation.output.indexWhere(_.exprId ==
a.exprId))
}
- iterator
- .map(batch =>
requestedColumns.map(batch(_)).map(ColumnAccessor(_)))
+ val rows = iterator
+ // Skip pruned batches
+ .filter { cachedBatch =>
+ if (!partitionFilter(cachedBatch.stats)) {
--- End diff --
Yeah exactly. I think in general it might be a good idea to guard these
kind of optimizations behind feature flags in case bugs are found in the
future. We can remove them after enough time has passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
