Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15971#discussion_r89408822
  
    --- Diff: 
core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala 
---
    @@ -95,6 +95,18 @@ class EventLoggingListenerSuite extends SparkFunSuite 
with LocalSparkContext wit
         }
       }
     
    +  test("Event logging with password redaction") {
    +    val key = "spark.executorEnv.HADOOP_CREDSTORE_PASSWORD"
    +    val secretPassword = "secret_password"
    +    val conf = getLoggingConf(testDirPath, None)
    +      .set(key, secretPassword)
    +    val eventLogger = new EventLoggingListener("test", None, 
testDirPath.toUri(), conf)
    +    val envDetails = SparkEnv.environmentDetails(conf, "FIFO", Seq.empty, 
Seq.empty)
    +    val event = SparkListenerEnvironmentUpdate(envDetails)
    +    val redactedProps = 
eventLogger.redactEvent(event).environmentDetails("Spark Properties").toMap
    --- End diff --
    
    "Spark Properties" is begging to be turned into a constant somewhere...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to