Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/15986#discussion_r89414630
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -525,7 +527,14 @@ private[spark] class TaskSchedulerImpl(
* of any running tasks, since the loss reason defines whether we'll
fail those tasks.
*/
private def removeExecutor(executorId: String, reason:
ExecutorLossReason) {
- executorIdToTaskCount -= executorId
+ executorIdToRunningTaskIds.remove(executorId).foreach { taskIds =>
--- End diff --
Can you add a comment here -- something like
The tasks on the lost executor may not send any more status updates
(because the executor has been lost), so they should be cleaned up here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
