Github user ChorPangChan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16000#discussion_r89563670
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/status/api/v1/JacksonMessageWriter.scala
---
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.streaming.status.api.v1
+
+import java.io.OutputStream
+import java.lang.annotation.Annotation
+import java.lang.reflect.Type
+import java.nio.charset.StandardCharsets
+import java.text.SimpleDateFormat
+import java.util.{Calendar, Locale, SimpleTimeZone}
+import javax.ws.rs.Produces
+import javax.ws.rs.core.{MediaType, MultivaluedMap}
+import javax.ws.rs.ext.{MessageBodyWriter, Provider}
+
+import com.fasterxml.jackson.annotation.JsonInclude
+import com.fasterxml.jackson.databind.{ObjectMapper, SerializationFeature}
+
+/**
+ * This class converts the POJO metric responses into json, using jackson.
+ *
+ * This doesn't follow the standard jersey-jackson plugin options, because
we want to stick
+ * with an old version of jersey (since we have it from yarn anyway) and
don't want to pull in lots
+ * of dependencies from a new plugin.
+ *
+ * Note that jersey automatically discovers this class based on its
package and its annotations.
+ */
+@Provider
+@Produces(Array(MediaType.APPLICATION_JSON))
+private[v1] class JacksonMessageWriter extends MessageBodyWriter[Object]{
+
--- End diff --
I agree in terms of functionality
but how about the design/structure
JacksonMessageWriter in spark-core is private to api.v1
Althouth we can use it though holder.setInitParameter
shoud we?
is there any sample of reusing the JacksonMessageWriter in other component?
I imaging someday in the future, sommeone will create a v2 api
and inside that v2 api, there will be another JacksonMessageWriter as well
because even they have the same function, I dont think they have the same
meaning
in order to share the class of JacksonMessageWriter
we may need to move it outside v1 first
and i think that will be too much to consider for our current goal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
