GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/16008
[SPARK-18585][SQL] Use `ev.isNull = "false"` if possible for Janino to have
a chance to optimize.
## What changes were proposed in this pull request?
Janino can optimize `true ? a : b` into `a` or `false ? a : b` into `b`, or
if/else with literal condition, so we should use literal as `ev.isNull` if
possible.
## How was this patch tested?
Existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ueshin/apache-spark issues/SPARK-18585
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16008.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16008
----
commit 6992bd08c410f5560f68cf59c3a9b139cc4464e8
Author: Takuya UESHIN <[email protected]>
Date: 2016-11-22T09:00:09Z
Use `isNull = "false"` if possible.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
