Github user a-roberts commented on the issue:

    https://github.com/apache/spark/pull/15736
  
    Back to working on the performance related JIRAs now, so based on the above 
helpful comments here's what I'll do
    
    Remove the .get.compare from the loop as suggested above - we'll do a .get  
upfront to get our comparator to use, eliminating the .get later
    
    Move the duplicated code into the WritablePartitionedPairCollection object 
so the two methods optimised here will call the above new method (let's say 
it's called getComparator) before returning accordingly (both methods are the 
same apart from the final few lines).
    
    PartitionedAppendOnlyMap returns 
    ```
    destructiveSortedIterator(comparator)
    ```
    
    and PartitionedPairBuffer returns:
    
    ```
    new Sorter(new KVArraySortDataFormat[(Int, K), AnyRef]).sort(data, 0, 
curSize, comparator)
    iterator
    ```
    
    I'll then build/test/profile this again


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to