Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16013#discussion_r89676820
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
    @@ -165,32 +165,56 @@ object ParamValidators {
             s" of unexpected input type: ${value.getClass}")
       }
     
    -  /** Check if value > lowerBound */
    +  /**
    +   * Check if
    +   * {{{
    +   * value > lowerBound
    +   * }}}
    +   */
       def gt[T](lowerBound: Double): T => Boolean = { (value: T) =>
         getDouble(value) > lowerBound
       }
     
    -  /** Check if value >= lowerBound */
    +  /**
    +   * Check if
    +   * {{{
    +   * value >= lowerBound
    +   * }}}
    +   */
       def gtEq[T](lowerBound: Double): T => Boolean = { (value: T) =>
         getDouble(value) >= lowerBound
       }
     
    -  /** Check if value < upperBound */
    +  /**
    +   * Check if
    +   * {{{
    +   * value < upperBound
    +   * }}}
    +   */
       def lt[T](upperBound: Double): T => Boolean = { (value: T) =>
         getDouble(value) < upperBound
       }
     
    -  /** Check if value <= upperBound */
    +  /**
    +   * Check if
    +   * {{{
    +   * value <= upperBound
    +   * }}}
    +   */
       def ltEq[T](upperBound: Double): T => Boolean = { (value: T) =>
         getDouble(value) <= upperBound
       }
     
       /**
        * Check for value in range lowerBound to upperBound.
    -   * @param lowerInclusive  If true, check for value >= lowerBound.
    -   *                        If false, check for value > lowerBound.
    -   * @param upperInclusive  If true, check for value <= upperBound.
    -   *                        If false, check for value < upperBound.
    +   * @param lowerInclusive {{{
    +   *                       If true, check for value >= lowerBound
    +   *                       If false, check for value > lowerBound
    +   *                       }}}
    +   * @param upperInclusive {{{
    +   *                       If true, check for value <= upperBound.
    +   *                       If false, check for value < upperBound.
    +   *                       }}}
    --- End diff --
    
    I am not sure if this is pretty but it at least better than the original 
one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to