Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r89679682
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -922,6 +923,29 @@ private[spark] class HiveExternalCatalog(conf:
SparkConf, hadoopConf: Configurat
/**
* Returns the partition names from hive metastore for a given table in
a database.
*/
+ override def listPartitionNames(
+ db: String,
+ table: String,
+ partialSpec: Option[TablePartitionSpec] = None): Seq[String] =
withClient {
+ val actualPartColNames = getTable(db, table).partitionColumnNames
+ val clientPartitionNames =
+ client.getPartitionNames(db, table,
partialSpec.map(lowerCasePartitionSpec))
+
+ if (actualPartColNames.exists(partColName => partColName !=
partColName.toLowerCase)) {
+ clientPartitionNames.map { partName =>
+ val partSpec = PartitioningUtils.parsePathFragmentAsSeq(partName)
--- End diff --
I don't think this is correct, and based on what I've found in the Hive
source code (and reading the DDL grammar on the Hive wiki) I'm going to push a
change with another proposal for partition column name/value handling.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
