Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16026#discussion_r89713119
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FilterPushdownSuite.scala
 ---
    @@ -514,6 +514,39 @@ class FilterPushdownSuite extends PlanTest {
         comparePlans(optimized, 
analysis.EliminateSubqueryAliases(correctAnswer))
       }
     
    +  test("joins: push down where clause into left anti join") {
    +    val x = testRelation.subquery('x)
    +    val y = testRelation.subquery('y)
    +    val originalQuery =
    +      x.join(y, LeftAnti, Some("x.b".attr === "y.b".attr))
    +        .where("x.a".attr > 10)
    +        .analyze
    +    val optimized = Optimize.execute(originalQuery)
    +    val correctAnswer =
    +      x.where("x.a".attr > 10)
    +        .join(y, LeftAnti, Some("x.b".attr === "y.b".attr))
    +        .analyze
    +    comparePlans(optimized, 
analysis.EliminateSubqueryAliases(correctAnswer))
    +  }
    +
    +  test("joins: only push down to the right of a left anti join") {
    --- End diff --
    
    How about `joins: only push down join conditions to the right of a left 
anti join`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to