Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r89715587
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -590,7 +591,11 @@ object ScalaReflection extends ScalaReflection {
"cannot be used as field name\n" +
walkedTypePath.mkString("\n"))
}
- val fieldValue = Invoke(inputObject, fieldName,
dataTypeFor(fieldType))
+ // primitive take only non-null or struct takes non-null object
guarded by isNull
--- End diff --
Yes, I agree that this part is little tricky. After waiting for other
comments, I will rephrase the comment on Tuesday.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
