Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/15986#discussion_r89716522
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -350,20 +350,16 @@ private[spark] class TaskSchedulerImpl(
removeExecutor(execId, reason.get)
failedExecutor = Some(execId)
}
+ }
+ if (TaskState.isFinished(state)) {
+ cleanupTaskState(tid)
--- End diff --
I don't think that's necessary because all access to the TSM is gated on
the TaskSchedulerImpl, so even though the TaskResultGetter might do some stuff,
the TSM's state won't be accessed until the later handleSuccessfulTask call to
the TaskSchedulerImpl
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
