Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/13557#discussion_r89817165
--- Diff: python/pyspark/ml/clustering.py ---
@@ -330,6 +357,20 @@ class KMeans(JavaEstimator, HasFeaturesCol,
HasPredictionCol, HasMaxIter, HasTol
>>> df = spark.createDataFrame(data, ["features"])
>>> kmeans = KMeans(k=2, seed=1)
>>> model = kmeans.fit(df)
+ >>> summary = model.summary
--- End diff --
Can we make this doc test the same as the other clustering classes? We
should test `model.hasSummary` before and after save/load as was done in the
other implementations. Also, we need to add a test to `tests.py` for this
summary (see that file and reference the other summary tests).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
