Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16033#discussion_r89942478
--- Diff:
core/src/main/scala/org/apache/spark/partial/ApproximateActionListener.scala ---
@@ -34,11 +34,13 @@ private[spark] class ApproximateActionListener[T, U, R](
rdd: RDD[T],
func: (TaskContext, Iterator[T]) => U,
evaluator: ApproximateEvaluator[U, R],
- timeout: Long)
+ timeout: Long = 1000*60*60*24*30*12,
--- End diff --
@Ru-Xiang that's orthogonal to what @srowen was suggesting. The issue here
is that the change is breaking binary compatibility for Spark applications.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
