Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2205#discussion_r17070804
  
    --- Diff: python/pyspark/broadcast.py ---
    @@ -59,11 +63,20 @@ def __init__(self, bid, value, java_broadcast=None,
             """
             self.bid = bid
             if path is None:
    -            self.value = value
    +            self._value = value
             self._jbroadcast = java_broadcast
             self._pickle_registry = pickle_registry
             self.path = path
     
    +    @property
    --- End diff --
    
    This is a good refactoring, especially how it allows `value` to be 
documented.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to