Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16046#discussion_r89977826
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1120,47 +1173,54 @@ class Analyzer(
} else {
a
}
- case w : Window =>
- failOnOuterReference(w)
- failOnNonEqualCorrelatedPredicate(foundNonEqualCorrelatedPred, w)
- w
- case j @ Join(left, _, RightOuter, _) =>
- failOnOuterReference(j)
- failOnOuterReferenceInSubTree(left, "a RIGHT OUTER JOIN")
- j
- // SPARK-18578: Do not allow any correlated predicate
- // in a Full (Outer) Join operator and its descendants
- case j @ Join(_, _, FullOuter, _) =>
- failOnOuterReferenceInSubTree(j, "a FULL OUTER JOIN")
- j
- case j @ Join(_, right, jt, _) if !jt.isInstanceOf[InnerLike] =>
- failOnOuterReference(j)
- failOnOuterReferenceInSubTree(right, "a LEFT (OUTER) JOIN")
+
+ // Join can host correlated expressions.
+ case j @ Join(left, right, joinType, _) =>
+ joinType match {
+ // Inner join, like Filter, can be anywhere.
+ // LeftSemi is a special case of Inner join which returns
+ // only the first matched row to the right table.
+ case _: InnerLike | LeftSemi =>
--- End diff --
We cannot pull-out a predicate which is defined in the right side of a
`LeftSemi` join. `LeftSemi` join should be treated like all a `LeftOuter`
join.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
