Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16060#discussion_r90060096
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala
---
@@ -51,9 +51,12 @@ private[spark] object HiveUtils extends Logging {
sc
}
- /** The version of hive used internally by Spark SQL. */
+ // The version of hive used internally by Spark SQL.
val hiveExecutionVersion: String = "1.2.1"
+ // The property key that is used to store the raw hive type string in
the metadata of StructField.
--- End diff --
I'd add a bit more color here, e.g. by adding an example: "For example, in
the case where the Hive type is varchar, the type gets mapped to a string type
in Spark SQL, but we need to preserve the original type in order to invoke the
correct object inspector in Hive"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
