Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/15982#discussion_r90082215
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriter.java ---
@@ -337,42 +340,38 @@ void forceSorterToSpill() throws IOException {
final int numPartitions = partitioner.numPartitions();
final long[] partitionLengths = new long[numPartitions];
final InputStream[] spillInputStreams = new
FileInputStream[spills.length];
- OutputStream mergedFileOutputStream = null;
+ final CountingOutputStream mergedFileOutputStream = new
CountingOutputStream(
--- End diff --
Could you add a comment about why need to use `CountingOutputStream` +
`CloseShieldOutputStream`? It took me a while to figure out the optimization
you did.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
