GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/16066
[SPARK-18632][SQL] AggregateFunction should not implement
ImplicitCastInputTypes
## What changes were proposed in this pull request?
`AggregateFunction` currently implements `ImplicitCastInputTypes` (which
enables implicit input type casting). There are actually quite a few situations
in which we don't need this, or require more control over our input. A recent
example is the aggregate for `CountMinSketch` which should only take string,
binary or integral types inputs.
This PR removes `ImplicitCastInputTypes` from the `AggregateFunction` and
makes a case-by-case decision on what kind of input validation we should use.
## How was this patch tested?
Refactoring only. Existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hvanhovell/spark SPARK-18632
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16066.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16066
----
commit 9a722cf3d48850ab6579db856876bada8749330c
Author: Herman van Hovell <[email protected]>
Date: 2016-11-29T20:56:53Z
AggregateFunction should not implement ImplicitCastInputTypes.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
