Github user rxin commented on the issue:

    https://github.com/apache/spark/pull/15877
  
    Hey guys - after looking at the pr more, I'm afraid we have gone overboard 
with testing here. Most of the test cases written are just repeating each other 
and doing exactly the same thing. For testing something like this I'd probably 
just have some simple end-to-end test and then be done with it, because most of 
the complicated logics are isolated in the actual CountMinSketch implementation 
itself and already has good test coverage.
     


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to