Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16067#discussion_r90176867
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala 
---
    @@ -58,13 +57,28 @@ abstract class QueryPlan[PlanType <: 
QueryPlan[PlanType]] extends TreeNode[PlanT
       }
     
       /**
    +   * Infer the Attribute-specific IsNotNull constraints from the null 
intolerant child expressions
    +   * of constraints.
    +   */
    +  private def inferIsNotNullConstraints(constraint: Expression): 
Seq[Expression] =
    +    constraint match {
    +      case IsNotNull(_: Attribute) => constraint :: Nil
    --- End diff --
    
    we don't this case, I think it can be covered by the next case?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to