Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/16021
  
    Hi, @rxin .
    
    All 6 commits are not cherry-pickable. Especially, the last 2 commits has 
inevitable conflicts due to some wide commits (about `import order` and 
`syntax` cleanups.)
    
    But, I can find the following clean cherry-pick sequences for the first 4 
commits.
    
    ```
    $ git cherry-pick -x 28112657ea5919451291c21b4b8e1eb3db0ec8d4
    $ git cherry-pick -x 0f6936b5f1c9b0be1c33b98ffb62a72ae0c3e2a8
    $ git cherry-pick -x 7f443a6879fa33ca8adb682bd85df2d56fb5fcda
    $ git cherry-pick -x 2aad2d372469aaf2773876cae98ef002fef03aa3
    $ git cherry-pick -x 554d840a9ade79722c96972257435a05e2aa9d88
    $ git cherry-pick -x 8c1b867cee816d0943184c7b485cd11e255d8130
    $ git cherry-pick -x 5c2682b0c8fd2aeae2af1adb716ee0d5f8b85135
    $ git cherry-pick -x ad5b7cfcca7a5feb83b9ed94b6e725c6d789579b
    $ git cherry-pick -x 94f7a12b3c8e4a6ecd969893e562feb7ffba4c24
    $ git diff HEAD~9 --stat
    
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
 | 102 +++++++++++++++++++++++++++++++++++---------------------
    sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala           
          |  68 ++++++++++++++++++++++++++++++++-----
    sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala        
          |  15 +++++++++
     3 files changed, 139 insertions(+), 46 deletions(-)
    ```
    
    All are related commits in the above three files. If you don't mind, could 
you cherry-pick the above. The followings are the titles of them.
    
    1. [SPARK-12236][SQL] JDBC filter tests all pass if filters are not really 
pushed down.
    2. [SPARK-12249][SQL] JDBC non-equality comparison operator not pushed down.
    3. [SPARK-12314][SQL] isnull operator not pushed down for JDBC datasource.
    4. [SPARK-12315][SQL] isnotnull operator not pushed down for JDBC 
datasource.
    5. Style fix for the previous 3 JDBC filter push down commits. (@rxin)
    6. [SPARK-12446][SQL] Add unit tests for JDBCRDD internal functions 
    7. [SPARK-12409][SPARK-12387][SPARK-12391][SQL] Support AND/OR/IN/LIKE 
push-down filters for JDBC
    8. [SPARK-12409][SPARK-12387][SPARK-12391][SQL] Refactor filter pushdown 
for JDBCRDD and add few filters (Liang-Chi Hsieh)
    9. [SPARK-10180][SQL] JDBC datasource are not processing EqualNullSafe 
filter 
    
    After your cherry-picking, I will create two PRs for the remaining 
inevitable-conflict commits.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to