GitHub user dongjoon-hyun reopened a pull request:

    https://github.com/apache/spark/pull/15863

    [SPARK-18419][SQL] Fix `JDBCOptions.asConnectionProperties` to be 
case-insensitive

    ## What changes were proposed in this pull request?
    
    `JDBCOptions.asConnectionProperties` is designed to filter JDBC options 
out, but it fails to handle `CaseInsensitiveMap`. For the following example, it 
returns `Map('numpartitions' -> "10")` as a wrong result and the assertion 
fails. This PR aims to fix `JDBCOptions.asConnectionProperties` to be 
case-insensitive.
    
    ```scala
    val options = new JDBCOptions(new CaseInsensitiveMap(Map(
        "url" -> "jdbc:mysql://localhost:3306/temp",
        "dbtable" -> "t1",
        "numPartitions" -> "10")))
    assert(options.asConnectionProperties.isEmpty)
    ```
    
    ## How was this patch tested?
    
    Pass the Jenkins with a new testcase.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dongjoon-hyun/spark SPARK-18419

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/15863.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15863
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to