Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/15237#discussion_r90543844
--- Diff: core/src/test/scala/org/apache/spark/scheduler/PoolSuite.scala ---
@@ -20,15 +20,21 @@ package org.apache.spark.scheduler
import java.util.Properties
import org.apache.spark.{LocalSparkContext, SparkConf, SparkContext,
SparkFunSuite}
+import org.apache.spark.scheduler.SchedulingMode._
/**
* Tests that pools and the associated scheduling algorithms for FIFO and
fair scheduling work
* correctly.
*/
class PoolSuite extends SparkFunSuite with LocalSparkContext {
+ val LOCAL = "local"
+ val APP_NAME = "PoolSuite"
+ val SCHEDULER_ALLOCATION_FILE_PROPERTY =
"spark.scheduler.allocation.file"
+ val SCHEDULER_POOL_PROPERTY = "spark.scheduler.pool"
--- End diff --
instead of repeating this here, why not directly access the constant in
`FairSchedulableBuilder`? would be better if it were in an `object`, but you
have an instance where you reference this in any case so you dont' need to do a
bigger refactoring.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
