Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11211#discussion_r90579292
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/PythonRunner.scala ---
    @@ -85,6 +85,7 @@ object PythonRunner {
         // pass conf spark.pyspark.python to python process, the only way to 
pass info to
         // python process is through environment variable.
         sparkConf.get(PYSPARK_PYTHON).foreach(env.put("PYSPARK_PYTHON", _))
    +    env.put("PYTHONHASHSEED", sys.env.getOrElse("PYTHONHASHSEED", "0"))
    --- End diff --
    
    I'd rather do `sys.env.get("PYTHONHASHSEED").foreach { ... }` to avoid 
polluting the environment when not needed. (Also to avoid hardcoding the 
default in multiple places.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to