Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16108#discussion_r90581685
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingQueryListenerSuite.scala
---
@@ -191,6 +193,48 @@ class StreamingQueryListenerSuite extends StreamTest
with BeforeAndAfter {
assert(queryQueryTerminated.exception === newQueryTerminated.exception)
}
+ test("only one progress event per interval when no data") {
+ // This test will start a query but not push any data, and then check
if we push too many events
+ withSQLConf(SQLConf.STREAMING_NO_DATA_EVENT_INTERVAL.key -> "100ms") {
+ @volatile var numProgressEvent = 0
+ val listener = new StreamingQueryListener {
+ override def onQueryStarted(event: QueryStartedEvent): Unit = {}
+ override def onQueryProgress(event: QueryProgressEvent): Unit = {
+ numProgressEvent += 1
+ }
+ override def onQueryTerminated(event: QueryTerminatedEvent): Unit
= {}
+ }
+ spark.streams.addListener(listener)
+ try {
+ val input = new MemoryStream[Int](0, sqlContext) {
+ @volatile var numTriggers = 0
+ override def getOffset: Option[Offset] = {
+ numTriggers += 1
+ super.getOffset
+ }
+ }
+ val clock = new StreamManualClock()
+ val actions = mutable.ArrayBuffer[StreamAction]()
+ actions += StartStream(trigger = ProcessingTime(10), triggerClock
= clock)
+ for (_ <- 1 to 100) {
+ actions += AdvanceManualClock(10)
+ }
+ actions += AssertOnQuery { _ =>
+ eventually(timeout(streamingTimeout)) {
+ assert(input.numTriggers > 100) // at least 100 triggers have
occurred
+ }
+ true
+ }
+ testStream(input.toDS)(actions: _*)
+ spark.sparkContext.listenerBus.waitUntilEmpty(10000)
+ // 11 is the max value of the possible numbers of events.
+ assert(numProgressEvent >= 1 && numProgressEvent <= 11)
--- End diff --
Shouldnt this be > 1? What if there is a bug that it only outputs once when
isData goes from true -> false, and never outputs again, irrespective of the
noDataInterval?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
