GitHub user yanboliang opened a pull request:

    https://github.com/apache/spark/pull/16117

    [SPARK-18686][SparkR][ML] Several cleanup and improvements for spark.logit.

    ## What changes were proposed in this pull request?
    Several cleanup and improvements for ```spark.logit```:
    * ```summary``` should return coefficients matrix, and should output labels 
for each class if the model is multinomial logistic regression model.
    * ```summary``` should not return ```areaUnderROC, roc, pr, ...```, since 
most of them are DataFrame which are less important for R users. Meanwhile, 
these metrics ignore instance weights (setting all to 1.0) which will be 
changed in later Spark version. In case it will introduce breaking changes, we 
do not expose them currently.
    * SparkR test improvement: comparing the training result with native R 
glmnet.
    * Remove argument ```aggregationDepth``` from ```spark.logit```, since it's 
an expert Param(related with Spark architecture and job execution) that would 
be used rarely by R users.
    
    ## How was this patch tested?
    Unit tests.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yanboliang/spark spark-18686

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/16117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #16117
    
----
commit e78adcd4a5685bbf292a864e77dc1b345854e047
Author: Yanbo Liang <yblia...@gmail.com>
Date:   2016-12-02T08:16:18Z

    Several cleanup and improvements for spark.logit.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to