Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16098#discussion_r90676226
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/SparkHadoopMapReduceWriter.scala
---
@@ -163,12 +164,23 @@ object SparkHadoopMapReduceWriter extends Logging {
outputMetricsAndBytesWrittenCallback, recordsWritten)
recordsWritten += 1
}
-
+ if (writer != null) {
+ writer.close(taskContext)
+ writer = null
+ }
committer.commitTask(taskContext)
}(catchBlock = {
- committer.abortTask(taskContext)
- logError(s"Task ${taskContext.getTaskAttemptID} aborted.")
- }, finallyBlock = writer.close(taskContext))
+ // If there is an error, release resource and then abort the task.
+ try {
+ if (writer != null) {
--- End diff --
So this is also adding a defensive close before aborting, not just before
committing? if that's important at all, OK. It didn't do that before.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
