Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/16122#discussion_r90721187
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -600,11 +600,14 @@ private[client] class Shim_v0_13 extends Shim_v0_12 {
.asInstanceOf[JArrayList[Partition]]
} catch {
case ex: InvocationTargetException if
ex.getCause.isInstanceOf[MetaException] &&
- !tryDirectSql =>
- logWarning("Caught Hive MetaException attempting to get
partition metadata by " +
- "filter from Hive. Falling back to fetching all partition
metadata, which will " +
- "degrade performance. Modifying your Hive metastore
configuration to set " +
- s"${tryDirectSqlConfVar.varname} to true may resolve this
problem.", ex)
+ (!tryDirectSql || ex.getCause.getMessage.contains(
--- End diff --
In hindsight, I believe this approach of testing the hive configuration may
be fundamentally flawed. When testing the value of
`HiveConf.ConfVars.METASTORE_TRY_DIRECT_SQL`, we need to know the value set in
the Hive Metastore server. What we're testing here is the setting in this Hive
client. They won't necessarily be the same, so we can get false positives and
false negatives of this test here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
