Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/16113#discussion_r90741307
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -605,34 +629,64 @@ class StreamExecution(
case object TERMINATED extends State
}
+
/**
- * Contains metadata associated with a stream execution. This information
is
- * persisted to the offset log via the OffsetSeq metadata field. Current
- * information contained in this object includes:
+ * Contains metadata associated with a [[StreamingQuery]]. This
information is written
+ * in the checkpoint location the first time a query is started and
recovered every time the query
+ * is restarted.
*
- * @param batchWatermarkMs: The current eventTime watermark, used to
- * bound the lateness of data that will processed. Time unit: milliseconds
- * @param batchTimestampMs: The current batch processing timestamp.
- * Time unit: milliseconds
+ * @param id unique id of the [[StreamingQuery]] that needs to be
persisted across restarts
*/
-case class StreamExecutionMetadata(
- var batchWatermarkMs: Long = 0,
- var batchTimestampMs: Long = 0) {
- private implicit val formats = StreamExecutionMetadata.formats
-
- /**
- * JSON string representation of this object.
- */
- def json: String = Serialization.write(this)
+case class StreamMetadata(id: String) {
--- End diff --
Can we move these to their own file?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
