Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16094#discussion_r90764328
  
    --- Diff: python/pyspark/sql/column.py ---
    @@ -298,19 +299,34 @@ def isin(self, *cols):
         isNotNull = _unary_op("isNotNull", "True if the current expression is 
not null.")
     
         @since(1.3)
    -    def alias(self, *alias):
    +    def alias(self, *alias, **kwargs):
             """
             Returns this column aliased with a new name or names (in the case 
of expressions that
             return more than one column, such as explode).
     
    +        Optional ``metadata`` keyword argument can be passed when aliasing 
a single column.
    --- End diff --
    
    2.2 is probably right, although the current 2.1 RC is more a of a strawman 
so it is possible (but up to @davies / @marmbrus if this warrants going into 
2.1).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to