Github user koertkuipers commented on a diff in the pull request: https://github.com/apache/spark/pull/15979#discussion_r90770824 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala --- @@ -47,16 +47,26 @@ object ExpressionEncoder { // We convert the not-serializable TypeTag into StructType and ClassTag. val mirror = typeTag[T].mirror val tpe = typeTag[T].tpe + + if (ScalaReflection.optionOfProductType(tpe)) { + throw new UnsupportedOperationException( + "Cannot create encoder for Option of Product type, because Product type is represented " + --- End diff -- this also means an Aggregator cannot use an Option of Product Type for its intermediate type. e.g. Aggregator[Int, Option[(Int, Int)], Int] is now invalid. but i see no good reason why such an Aggregator wouldnt exist?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org