Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16082#discussion_r90774722
  
    --- Diff: python/setup.py ---
    @@ -69,10 +69,13 @@
     
     EXAMPLES_PATH = os.path.join(SPARK_HOME, "examples/src/main/python")
     SCRIPTS_PATH = os.path.join(SPARK_HOME, "bin")
    +DATA_PATH = os.path.join(SPARK_HOME, "data")
     SCRIPTS_TARGET = os.path.join(TEMP_PATH, "bin")
     JARS_TARGET = os.path.join(TEMP_PATH, "jars")
     EXAMPLES_TARGET = os.path.join(TEMP_PATH, "examples")
    -
    +DATA_TARGET = os.path.join(TEMP_PATH, "data")
    +LICENSES_PATH = os.path.join(SPARK_HOME, "licenses")
    --- End diff --
    
    Super minor, and sorry I didn't notice it earlier, but we define all of the 
_PATHs before the target - just for someone skimming the code would be good to 
keep the current flow.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to