Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16059#discussion_r90776114
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -175,6 +183,8 @@ final class OneVsRestModel private[ml] (
val updateUDF = udf { (predictions: Map[Int, Double], prediction:
Vector) =>
predictions + ((index, prediction(1)))
}
+ model.setFeaturesCol($(featuresCol))
+ model.setPredictionCol($(predictionCol))
--- End diff --
It's not necessary to ```setPredictionCol``` here, since the prediction
column of each base binary classifier is ignored during the transformation. The
```predictionCol``` of ```OneVsRestModel``` was set at L198.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
