Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15664#discussion_r90826780
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -112,7 +112,25 @@ object JdbcUtils extends Logging {
*/
def insertStatement(conn: Connection, table: String, rddSchema:
StructType, dialect: JdbcDialect)
: PreparedStatement = {
- val columns = rddSchema.fields.map(x =>
dialect.quoteIdentifier(x.name)).mkString(",")
+ // Use database column names instead of RDD schema column names
+ val tableSchemaQuery =
conn.prepareStatement(dialect.getSchemaQuery(table))
--- End diff --
I think the table schema won't change during inserting all data. You ask
table schema for every insert statement now. Can we do this once in caller side
(i.e., `savePartition`) and reuse the schema then?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
